Skip to content

Enable checksum validation by default in install-gh-aw.sh #26476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+17 −19
Closed

Enable checksum validation by default in install-gh-aw.sh #26476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ae3a5b
enable checksum validation by default in install-gh-aw.sh
Copilot Apr 15, 2026
a045fa1
fix: use correct script name in header and clarify latest means lates…
Copilot Apr 15, 2026
f2d59ef
fix: update latest stable wording in actions/setup-cli/install.sh
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions actions/setup-cli/install.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 8 additions & 9 deletions install-gh-aw.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

# Script to download and install gh-aw binary for the current OS and architecture
# Supports: Linux, macOS (Darwin), FreeBSD, Windows (Git Bash/MSYS/Cygwin)
# If no version is specified, it will use "latest"
# Note: Checksum validation is currently skipped by default (will be enabled in future releases)
# If no version is specified, it will install the latest stable release.
# Checksum validation is enabled by default to protect against tampering.
#
# Usage: ./install.sh [version] [options]
# Usage: ./install-gh-aw.sh [version] [options]
#
# Examples:
# ./install.sh # Install latest version
# ./install.sh v1.0.0 # Install specific version
# ./install.sh --skip-checksum # Skip checksum validation
# ./install-gh-aw.sh # Install latest stable version
# ./install-gh-aw.sh v1.0.0 # Install specific version
# ./install-gh-aw.sh v1.0.0 --skip-checksum # Install without checksum validation
#
# Options:
# --skip-checksum Skip checksum verification
Expand All @@ -19,15 +19,14 @@
set -e # Exit on any error

# Parse arguments
SKIP_CHECKSUM=true # Default to true until checksums are available in releases
SKIP_CHECKSUM=false # Checksum validation enabled by default
TRY_GH_INSTALL=false # Whether to try gh extension install first
VERSION=""

# Check if INPUT_VERSION is set (GitHub Actions context)
if [ -n "$INPUT_VERSION" ]; then
VERSION="$INPUT_VERSION"
TRY_GH_INSTALL=true # In GitHub Actions, try gh install first
SKIP_CHECKSUM=false # Enable checksum validation in GitHub Actions
fi

for arg in "$@"; do
Expand Down Expand Up @@ -168,7 +167,7 @@ print_info "Platform: $PLATFORM"
REPO="github/gh-aw"

if [ -z "$VERSION" ]; then
print_info "No version specified, using 'latest'..."
print_info "No version specified, using latest stable release..."
VERSION="latest"
else
print_info "Using specified version: $VERSION"
Expand Down
6 changes: 3 additions & 3 deletions scripts/test-install-script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,10 @@ echo ""
echo "Test 10: Verify 'latest' version functionality"

# Check for "latest" as default version
if grep -q "using 'latest'" "$PROJECT_ROOT/install-gh-aw.sh"; then
echo " ✓ PASS: Script uses 'latest' as default version"
if grep -q "latest stable" "$PROJECT_ROOT/install-gh-aw.sh"; then
echo " ✓ PASS: Script uses 'latest stable' as default version"
else
echo " ✗ FAIL: Script does not use 'latest' as default version"
echo " ✗ FAIL: Script does not use 'latest stable' as default version"
exit 1
fi

Expand Down
Loading