chore: update GoogleUtils#getCertificateTrustStore to first attempt t… #2613
+130
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o load JSDK default certs
ldetmer
force-pushed
the
use-jdk-default-certs
branch
from
e20a107 to
d1f59c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in stopping maintenance for custom keystore in google-api-java-client see: go/stop-keystore-api-java-client
It updates GoogleUtils.getCertificateTrustStore() to first attempt to load java jdk default certs using logic similar to java's internal TrustStoreManager class before falling back to the custom keystore bundled with google-api-java-client. This is to alleviate issues with the bundled keystore having expired/missing certs
Deprecates GoogleUtils.getCertificateTrustStore()
Deprecates GoogleNetHttpTransport
updates documentation to refer users to NetHttpTransport
Tested using GoogleNetHttpTransport.newTrustedTransport() to make call to storage API.