fix: Escape HTML in display_explanations to prevent stored XSS#6613
Open
instantraaamen wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: Escape HTML in display_explanations to prevent stored XSS#6613instantraaamen wants to merge 1 commit intogoogleapis:mainfrom
instantraaamen wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Column names and cell values from evaluation DataFrames are rendered via IPython.display.HTML without sanitization. A crafted DataFrame (e.g. from a shared dataset or model output) can inject arbitrary HTML/JS that executes in the Colab/Jupyter session. Apply html.escape() to both column headers and cell values before interpolation, consistent with the escaping already used elsewhere in the codebase. Fixes both vertexai/evaluation and vertexai/preview/evaluation paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
display_explanations()innotebook_utils.pyrenders column names and cell values from evaluation DataFrames directly intoIPython.display.HTML()without escaping. If a DataFrame contains crafted HTML/JS payloads (e.g. from a shared dataset or model output), they execute in the user's Colab/Jupyter session.This applies
html.escape()to both column headers and cell values before interpolation, matching the pattern already used in_evals_visualization.py.Fixes both
vertexai/evaluationandvertexai/preview/evaluationpaths.Reproducer