Skip to content

fix: Escape HTML in display_explanations to prevent stored XSS #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
instantraaamen wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix: Escape HTML in display_explanations to prevent stored XSS #6613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vertexai/evaluation/notebook_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#
"""Python functions which run only within a Jupyter or Colab notebook."""

import html as html_lib
import random
import string
import sys
Expand Down Expand Up @@ -153,7 +154,9 @@ def display_explanations(

for _, row in df.iterrows():
for col in df.columns:
display(HTML(f"<div style='{style}'><h4>{col}:</h4>{row[col]}</div>"))
safe_col = html_lib.escape(str(col))
safe_val = html_lib.escape(str(row[col]))
display(HTML(f"<div style='{style}'><h4>{safe_col}:</h4>{safe_val}</div>"))
display(HTML("<hr>"))


Expand Down
5 changes: 4 additions & 1 deletion vertexai/preview/evaluation/notebook_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#
"""Python functions which run only within a Jupyter or Colab notebook."""

import html as html_lib
import random
import string
import sys
Expand Down Expand Up @@ -153,7 +154,9 @@ def display_explanations(

for _, row in df.iterrows():
for col in df.columns:
display(HTML(f"<div style='{style}'><h4>{col}:</h4>{row[col]}</div>"))
safe_col = html_lib.escape(str(col))
safe_val = html_lib.escape(str(row[col]))
display(HTML(f"<div style='{style}'><h4>{safe_col}:</h4>{safe_val}</div>"))
display(HTML("<hr>"))


Expand Down