Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30539
What is the current behavior?
Currently,
supportsPassivein the gesture listener utils detects passive listener support by attaching a realoptsTestlistener to the element and reading thepassivegetter, but it never removes that listener. The result is a listener permanently attached to whichever element runs the first gesture.There's a second failure mode in the same function. The
_sPassive === undefinedguard only clears if the getter fires or ifaddEventListenerthrows, so a runtime that does neither leaves_sPassiveundefined and every subsequent call attaches anotheroptsTestlistener that's never cleaned up.What is the new behavior?
We now always pass the options object, and the detection is removed entirely. The check was already dead code, because passive options object support landed in Chrome 51, Safari 10, Firefox 49, and Edge 16, all in 2016, while our lowest supported versions are Chrome 89, Safari 15, Firefox 75, and Edge 89. The function returned
trueon every browser we support, so both branches of the removed ternary collapse to the same value and there's no behavior change.Does this introduce a breaking change?
Other information