Skip to content

fix(gesture): remove leaked optsTest listener from passive support check #31363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShaneK merged 1 commit into from
Aug 18, 2026
+4 −32
Merged

fix(gesture): remove leaked optsTest listener from passive support check #31363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions core/src/utils/gesture/listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@ export const addEventListener = (
capture?: boolean;
}
): (() => void) => {
// use event listener options when supported
// otherwise it's just a boolean for the "capture" arg
const listenerOpts = supportsPassive(el)
? {
capture: !!opts.capture,
passive: !!opts.passive,
}
: !!opts.capture;
const listenerOpts = {
capture: !!opts.capture,
passive: !!opts.passive,
};

let add: string;
let remove: string;
Expand All @@ -31,27 +27,3 @@ export const addEventListener = (
el[remove](eventName, callback, listenerOpts);
};
};

const supportsPassive = (node: Node) => {
if (_sPassive === undefined) {
try {
const opts = Object.defineProperty({}, 'passive', {
get: () => {
_sPassive = true;
},
});
node.addEventListener(
'optsTest',
() => {
return;
},
opts
);
} catch (e) {
_sPassive = false;
}
}
return !!_sPassive;
};

let _sPassive: boolean | undefined;
Loading