Skip to content

Skip TestExtractAndReplacePreservesSpecialModeBits when setgid is not permitted - #534

Merged
purcell merged 1 commit into
mainfrom
skip-test-on-setgid-failure
Oct 5, 2026
Merged

purcell merged 1 commit into
mainfrom
skip-test-on-setgid-failure

Conversation

@purcell

@purcell purcell commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

In certain build environments, e.g. sandboxed Nix, the build process is not allowed to set security-sensitive flags on files. When this is the case, we should skip the above test rather than fail.

This has been preventing Nix from updating/building the latest version of the lstk package for a short while.

… permitted

In certain build environments, e.g. sandboxed Nix, the build process
is not allowed to set security-sensitive flags on files. When this is
the case, we should skip the above test rather than fail.
@purcell
purcell requested review from a team and peter-smith-phd as code owners October 5, 2026 13:40
@purcell purcell added the docs: skip Pull request does not require documentation changes label Oct 5, 2026
@purcell
purcell requested a review from carillan81 October 5, 2026 13:44
@purcell

purcell commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @anisaoshafi, will merge now so that (along with #532) the next release should update and build cleanly in nixpkgs.

@purcell
purcell merged commit f2c4401 into main Oct 5, 2026
25 checks passed
@purcell
purcell deleted the skip-test-on-setgid-failure branch October 5, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes semver: patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants