Feat/new spl flow by GabrielePicco · Pull Request #67 · magicblock-labs/magicblock-engine-examples

GabrielePicco · 2026-03-19T16:03:27Z

Summary by CodeRabbit

Release Notes

New Features
- Transfer visibility control: choose between public and private transfer modes
- Balance source/destination selection: route transfers between base and ephemeral balances
- Private transfer queue configuration: adjust minimum/maximum delay and split count for private transfers
Improvements
- Enhanced error reporting with detailed transaction logs for troubleshooting
Dependencies
- Updated ephemeral rollups SDK to the latest version

vercel · 2026-03-19T16:03:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
er-rolldice	Ready	Preview, Comment	Mar 19, 2026 4:03pm
magicblock-engine-examples	Ready	Preview, Comment	Mar 19, 2026 4:03pm

coderabbitai · 2026-03-19T16:08:06Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 34abb33a-16f9-4eab-9418-bc9f1b7fdf86

📥 Commits

Reviewing files that changed from the base of the PR and between c0a3653 and 9363814.

⛔ Files ignored due to path filters (2)

spl-tokens/app/app/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
spl-tokens/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (4)

spl-tokens/app/app/package.json
spl-tokens/app/app/src/App.tsx
spl-tokens/app/app/tsconfig.tsbuildinfo
spl-tokens/package.json

Walkthrough

Updated @magicblock-labs/ephemeral-rollups-sdk from version 0.7.2 to ^0.10.0 and changed its reference from a registry version to a local filesystem path. Removed @solana/spl-token dependency. Refactored App.tsx to replace transfer mode logic with new visibility and balance configuration options, implement enhanced error handling, and update balance subscription and delegation workflows.

Changes

Cohort / File(s)	Summary
Dependency updates `spl-tokens/app/app/package.json`	Updated `@magicblock-labs/ephemeral-rollups-sdk` from `0.7.2` to `^0.10.0` and removed `@solana/spl-token` dependency entirely.
Local SDK reference `spl-tokens/package.json`	Changed `@magicblock-labs/ephemeral-rollups-sdk` from pinned registry version (`0.7.1`) to local filesystem path (`file:/Users/.../ephemeral-rollups-sdk/ts/web3js`).
App refactoring `spl-tokens/app/app/src/App.tsx`	Replaced boolean `useEphemeral` with multi-option state (`transferVisibility`, `fromBalance`, `toBalance`, private queue parameters); added `formatTransactionError` for richer error handling; reworked balance subscriptions using `onAccountChange`; refactored transfer execution, setup flow, and delegation workflows to use SDK helpers; updated UI controls.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/new-spl-flow

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9363814db3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T16:15:03Z

spl-tokens/package.json

  "dependencies": {
    "@coral-xyz/anchor": "0.31.1",
-    "@magicblock-labs/ephemeral-rollups-sdk": "0.7.1"
+    "@magicblock-labs/ephemeral-rollups-sdk": "file:/Users/gabrielepicco/Documents/Solana/ephemeral-rollups-sdk/ts/web3js"


Restore a published SDK dependency in spl-tokens/package.json

This replaces the SDK with a machine-local file: path. The spl-tokens package owns the example's test script, so any clone or CI runner outside /Users/gabrielepicco/... will fail yarn install before it can run the tests or the example. Please keep this on a published version (or a repo-relative workspace path) instead of an absolute host path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-19T16:15:03Z

spl-tokens/app/app/src/App.tsx

-            setTransactionSuccess(`Transfer confirmed: ${sig.substring(0, 10)}...${sig.substring(sig.length - 10, sig.length)}`);
+            setTransactionSuccess(`${usesQueuedPrivateTransfer ? 'Private transfer queued' : 'Transfer confirmed'}: ${sig.substring(0, 10)}...${sig.substring(sig.length - 10, sig.length)}`);
+            console.log("Transfer: ", sig);
+            await ephemeralConnection!.current!.getAccountInfo(shuttleWalletAta);


Don't turn confirmed L1 transfers into UI errors

After conn.confirmTransaction(...) succeeds, this unconditional read against ephemeralConnection.current can still throw. For transfers that actually ran on connection (fromBalance === 'base', including base→base queueing), an ephemeral RPC outage or propagation lag now sends execution into the catch path and reports the transfer as failed even though it already landed on L1. This follow-up read should be best-effort or limited to the flows that truly require the ephemeral account.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-19T16:15:03Z

spl-tokens/app/app/src/App.tsx

+                    initRentPdaIx(
+                        payer.publicKey,
+                        rentPda,
+                    ),


Avoid re-initializing the shared rent PDA on every setup

deriveRentPda() returns a singleton PDA, but setupAll now unconditionally appends initRentPdaIx(...) to every mint-setup transaction. That makes the exposed Reset Mint → Setup flow brittle: once a previous run has already created the rent sponsor PDA on this cluster, the next setup will try to initialize the same account again and fail. This needs an existence check or an idempotent init path.

Useful? React with 👍 / 👎.

GabrielePicco added 12 commits March 9, 2026 13:56

feat: simplify spl flow

356c538

fix: undelegation with closure

7a61272

fix: crank

4222a4c

fix: add to queue

29cdb48

fix: add to queue

ab24cd7

fix: add queue fees

39fb26e

fix: use merged flow

798c094

fix: init rent sponsor pda

baa5295

feat: 1 tx undelegation

4535222

feat: private transfers apu

aa6c872

feat: add logs

876198d

chore: refactor

9363814

vercel bot deployed to Preview – er-rolldice March 19, 2026 16:03 View deployment

vercel bot deployed to Preview – roll-dice-demo March 19, 2026 16:03 View deployment

vercel bot deployed to Preview – magicblock-engine-examples March 19, 2026 16:03 View deployment

GabrielePicco merged commit 98d543d into main Mar 19, 2026
4 of 6 checks passed

GabrielePicco deleted the feat/new-spl-flow branch March 19, 2026 16:04

vercel bot deployed to Preview – spl-tokens March 19, 2026 16:05 View deployment

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

This was referenced Mar 22, 2026

chore: upgrade spl example #68

Merged

chore: upgrade spl example #69

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/new spl flow#67

Feat/new spl flow#67
GabrielePicco merged 12 commits intomainfrom
feat/new-spl-flow

GabrielePicco commented Mar 19, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

Review failed

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

GabrielePicco commented Mar 19, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

vercel bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

GabrielePicco commented Mar 19, 2026 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 19, 2026 •

edited

Loading

coderabbitai bot commented Mar 19, 2026 •

edited

Loading