Add electrical-engineer persona, schematic-compliance-audit protocol, and review-schematic template#97
Merged
Alan-Jowett merged 5 commits intomicrosoft:mainfrom Mar 29, 2026
Conversation
… and review-schematic template Phase 1 of microsoft#91 — PromptKit's first non-software engineering domain. - Persona: electrical-engineer — expertise in power delivery, signal integrity, voltage domain crossings, ESD protection, component selection, and standard interfaces. Conservative about datasheet margins. Thinks in voltage domains and current paths. - Protocol: schematic-compliance-audit (analysis) — 7-phase systematic schematic review: power architecture, pin-level audit, bus integrity, protection circuits, power sequencing/reset, passive component verification, and completeness check. - Template: review-schematic — audits a netlist or schematic against requirements and datasheets. Produces investigation-report with findings categorized by protocol phase. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PromptKit’s first electrical-engineering domain components to enable schematic/netlist audits against requirements and datasheets, using the existing investigation-report output format.
Changes:
- Introduces a new
electrical-engineerpersona for EE-focused review behavior and constraints. - Adds
schematic-compliance-auditanalysis protocol with a 7-phase schematic review methodology. - Adds
review-schematictemplate and registers all new components inmanifest.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| templates/review-schematic.md | New template that orchestrates schematic/netlist review using the new persona + protocol and investigation-report format. |
| protocols/analysis/schematic-compliance-audit.md | New 7-phase EE schematic audit protocol (power, pins, buses, protection, sequencing, passives, completeness). |
| personas/electrical-engineer.md | New EE persona defining expertise areas and behavioral constraints for schematic reviews. |
| manifest.yaml | Registers the new persona, protocol, and template under the existing manifest structure. |
- Align epistemic label to [ASSUMPTION] per anti-hallucination protocol - Use global severity ordering instead of grouping by category - Remove references to not-yet-existing templates in Non-Goals Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Protocol: reframe USB differential pair check as schematic-verifiable connectivity (not layout routing). Add layout carry-forward note. - Protocol: reframe ESD placement check as schematic topology verification. Flag physical placement as layout carry-forward. - Template: soften layout non-goal to allow noting layout-critical constraints as carry-forward items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #91 — PromptKit's first non-software engineering domain. Adds electrical engineering schematic review capability.
New Components
Design Decisions
Remaining phases (#91)
Checklist