Fix Python wire encoding type regression - #11619
Closed
Libba Lawrence (l0lawrence) wants to merge 3 commits into
Closed
Fix Python wire encoding type regression#11619Libba Lawrence (l0lawrence) wants to merge 3 commits into
Libba Lawrence (l0lawrence) wants to merge 3 commits into
Conversation
Preserve supported client-facing types when TCGC supplies wire types for boolean, integer, and byte encodings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f0bffcdc-e290-4621-980a-834a1e67bdc2
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Copilot started reviewing on behalf of
Libba Lawrence (l0lawrence)
August 11, 2026 18:58
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the TypeSpec Python HTTP client emitter where the presence of wireType on encoded built-in scalars caused the emitter to treat otherwise-supported encodings as unsupported, incorrectly changing the client-facing type (notably for booleans, integers, and bytes).
Changes:
- Preserve the original Python client type for supported encodings (boolean/integer encoded as
"string", bytes encoded as"base64"/"base64url") even whenwireTypeis present. - Keep the existing fallback behavior: for unknown/custom encodings, expose the
wireType-based type while retaining theencodevalue. - Add focused unit tests covering the supported combinations and the custom-encoding fallback, plus a Chronus changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/http-client-python/emitter/src/types.ts | Updates built-in type emission to preserve supported encoded client types while keeping wire-type fallback for unsupported/custom encodings. |
| packages/http-client-python/emitter/test/types.test.ts | Adds unit tests validating supported encoding preservation and the custom-encoding wire-type fallback path. |
| .chronus/changes/fix-python-wire-encoding-2026-08-11.md | Adds a changelog entry documenting the regression fix for Python wire encoding handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f0bffcdc-e290-4621-980a-834a1e67bdc2
Libba Lawrence (l0lawrence)
marked this pull request as ready for review
August 11, 2026 19:16
Libba Lawrence (l0lawrence)
requested review from
ChenxiJiang333,
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
August 11, 2026 19:16
Member
Author
|
Superseded by #11637, which is based on a branch in microsoft/typespec (not a fork) so the emitter-diff check runs. Closing this one. |
JoshLove-msft
pushed a commit
to JoshLove-msft/typespec
that referenced
this pull request
Aug 13, 2026
TCGC now supplies `wireType` for boolean, integer, and bytes encodings. The Python emitter treated every encoded type with a wire type as unsupported, replacing the client-facing type and regressing existing boolean, numeric, and byte serialization behavior. This change preserves the normal Python type for supported string, base64, and base64url encodings while retaining the wire-type fallback for custom or unsupported encodings. It also documents that fallback behavior and adds focused emitter coverage for the supported combinations and custom-encoding path. This PR supersedes microsoft#11619 (which was opened from a fork and therefore skipped the emitter-diff check). ## Validation - `npm run build` - `npm run format` - `npm run lint -- --emitter` - `npm run test:emitter` (13 tests) - `npm run regenerate` (Azure and unbranded) - Targeted boolean, numeric, and bytes mock tests (26 tests per flavor) --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Copilot-Session: f0bffcdc-e290-4621-980a-834a1e67bdc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCGC now supplies
wireTypefor boolean, integer, and bytes encodings. The Python emitter treated every encoded type with a wire type as unsupported, replacing the client-facing type and regressing existing boolean, numeric, and byte serialization behavior.This change preserves the normal Python type for supported string, base64, and base64url encodings while retaining the wire-type fallback for custom or unsupported encodings. It also documents that fallback behavior and adds focused emitter coverage for the supported combinations and custom-encoding path.
Validation
npm run buildnpm run formatnpm run lint -- --emitternpm run test:emitter(13 tests)npm run regenerate(Azure and unbranded)