Fix Python wire encoding type regression - #11637
Merged
Merged
Conversation
Preserve supported client-facing types when TCGC supplies wire types for boolean, integer, and byte encodings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f0bffcdc-e290-4621-980a-834a1e67bdc2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f0bffcdc-e290-4621-980a-834a1e67bdc2
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
|
You can try these changes here
|
Libba Lawrence (l0lawrence)
marked this pull request as ready for review
August 12, 2026 16:05
Libba Lawrence (l0lawrence)
requested review from
ChenxiJiang333,
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
August 12, 2026 16:05
iscai-msft
reviewed
Aug 12, 2026
iscai-msft
approved these changes
Aug 12, 2026
Yuchao Yan (msyyc)
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCGC now supplies
wireTypefor boolean, integer, and bytes encodings. The Python emitter treated every encoded type with a wire type as unsupported, replacing the client-facing type and regressing existing boolean, numeric, and byte serialization behavior.This change preserves the normal Python type for supported string, base64, and base64url encodings while retaining the wire-type fallback for custom or unsupported encodings. It also documents that fallback behavior and adds focused emitter coverage for the supported combinations and custom-encoding path.
This PR supersedes #11619 (which was opened from a fork and therefore skipped the emitter-diff check).
Validation
npm run buildnpm run formatnpm run lint -- --emitternpm run test:emitter(13 tests)npm run regenerate(Azure and unbranded)