[codex-analytics] replay protocol-native item timing#20239
Closed
rhan-oai wants to merge 2 commits intorhan/app-server-item-timingfrom
Closed
[codex-analytics] replay protocol-native item timing#20239rhan-oai wants to merge 2 commits intorhan/app-server-item-timingfrom
rhan-oai wants to merge 2 commits intorhan/app-server-item-timingfrom
Conversation
This was referenced Apr 29, 2026
rhan-oai
force-pushed
the
pr20239
branch
4 times, most recently
from
93b611d to
a5f2318
Compare
rhan-oai
added a commit
that referenced
this pull request
Apr 29, 2026
## Why Codex analytics needs a typed seam for app-server-originated request/response traffic so future tool-approval analytics can consume those facts without adding bespoke callsite tracking each time. Server responses arrive as JSON-RPC `id + result` payloads, so analytics has to reconstruct the matching typed response from the original typed request while that request context still exists in app-server. This also puts analytics on the app-server outbound path, which needs to avoid keeping the runtime alive during shutdown. The final ownership fix keeps the normal strong auth-manager retention in analytics and makes the external-auth refresh bridge hold a weak back-reference to `OutgoingMessageSender`, breaking the runtime cycle at the bridge boundary instead of exposing retention policy through the analytics client API. ## What changed - Adds typed `ServerRequest` and `ServerResponse` analytics facts, plus `AnalyticsEventsClient::track_server_request` and `track_server_response`. - Renames the existing client-side facts to `ClientRequest` and `ClientResponse` so reducers can distinguish client-to-server traffic from server-to-client traffic. - Adds `ServerRequest::response_from_result`, allowing a stored typed request to decode the matching typed server response from a raw JSON-RPC result payload. - Threads `AnalyticsEventsClient` through `OutgoingMessageSender` and records targeted server requests, replayed targeted requests, and matching targeted responses with the responding connection id needed for correlation. - Intentionally leaves broadcast server requests/responses out of analytics for now because the current model is per connection, while broadcasts fan one logical request out across multiple connections. - Breaks the app-server shutdown cycle by storing `Weak<OutgoingMessageSender>` in `ExternalAuthRefreshBridge` and upgrading it only when an external-auth refresh is actually requested. - Keeps reducer ingestion of the new server-side facts as no-ops for now; this PR is plumbing for later tool-approval analytics work. ## Verification - `cargo test -p codex-analytics` - `cargo test -p codex-app-server outgoing_message::tests::` - Covers typed-response reconstruction plus the targeted, replayed, broadcast-exclusion, and response-attribution analytics paths. ## Follow-up This PR intentionally stops at ingestion plumbing, so `ServerRequest` and `ServerResponse` facts are still reducer no-ops. Once a follow-up PR adds real downstream analytics output for those facts: - replace the temporary pre-reducer observation seam with reducer tests for the emitted event shape; - add end-to-end coverage in `app-server/tests/suite/v2/analytics.rs` for the real app-server workflow and captured analytics payload; - remove the temporary sender-level observer tests added here in favor of the real-output coverage above. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/17088). * #18748 * #18747 * #17090 * #17089 * #20241 * #20239 * __->__ #17088
rhan-oai
force-pushed
the
pr20239
branch
5 times, most recently
from
e238b73 to
51e71ee
Compare
rhan-oai
force-pushed
the
pr20239
branch
2 times, most recently
from
5210475 to
d5bedde
Compare
rhan-oai
force-pushed
the
pr20239
branch
2 times, most recently
from
4dfe7b0 to
e256fae
Compare
This was referenced Apr 30, 2026
rhan-oai
force-pushed
the
rhan/thread-analytics-state
branch
2 times, most recently
from
3fc7386 to
d877e6a
Compare
rhan-oai
force-pushed
the
pr20239
branch
4 times, most recently
from
3ba9aa2 to
effe7c6
Compare
rhan-oai
changed the title
rhan-oai
changed the base branch from
rhan/thread-analytics-state
to
rhan/app-server-item-timing
This was referenced Apr 30, 2026
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
from
65ef7bc to
84e66f0
Compare
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
from
84e66f0 to
0cf1a11
Compare
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
from
0cf1a11 to
e15f9f5
Compare
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
from
e15f9f5 to
e77df6b
Compare
rhan-oai
added a commit
that referenced
this pull request
May 1, 2026
## Why Several analytics event families need the same per-thread attribution state: the app-server client/runtime associated with a thread and, for lifecycle-oriented events, the thread metadata captured during initialization. Keeping connection ids and lifecycle metadata in separate maps made each consumer rebuild the same thread context and made subagent attribution harder to resolve consistently. ## What changed - Replaces the separate thread connection and metadata maps with one reducer-owned `threads` map. - Routes guardian, compaction, turn-steer, and turn analytics through shared thread-state lookups while preserving turn-origin attribution for turn events and request-origin attribution for steer events. - Lets newly observed spawned subagent threads inherit their parent thread connection so later thread-scoped analytics can resolve through the same state model. - Adds regression coverage for standalone `SubAgentThreadStarted` publication plus the `SubAgentSource::ThreadSpawn` parent fallback through a thread-scoped consumer that depends on inherited connection state. ## Verification - `cargo test -p codex-analytics` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/20300). * #18748 * #18747 * #17090 * #17089 * #20239 * #20515 * #20514 * __->__ #20300
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
3 times, most recently
from
087ce59 to
a862056
Compare
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
from
a862056 to
158fe58
Compare
rhan-oai
force-pushed
the
rhan/app-server-item-timing
branch
from
158fe58 to
27e04d5
Compare
Collaborator
Author
|
Superseded by the collapsed two-PR timing split; the remaining compile-required changes now live in #20515. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Once protocol-native lifecycle timing is available on the public app-server surface, replay consumers need to preserve it instead of rebuilding partial legacy-only events. Keeping that adapter layer separate makes it clear which changes are about consumption rather than production or wire shape.
What changed
Verification
cargo test -p codex-exec event_processor_with_json_outputcargo test -p codex-tui --no-runStack created with Sapling. Best reviewed with ReviewStack.