[codex-analytics] add core item timing production#20514
Draft
[codex-analytics] add core item timing production#20514
Conversation
This was referenced Apr 30, 2026
rhan-oai
force-pushed
the
rhan/core-item-timing-production
branch
from
5c272b8 to
c6e0ea5
Compare
rhan-oai
force-pushed
the
rhan/core-item-timing-production
branch
2 times, most recently
from
7a61984 to
88c1fb0
Compare
rhan-oai
added a commit
that referenced
this pull request
May 1, 2026
## Why Several analytics event families need the same per-thread attribution state: the app-server client/runtime associated with a thread and, for lifecycle-oriented events, the thread metadata captured during initialization. Keeping connection ids and lifecycle metadata in separate maps made each consumer rebuild the same thread context and made subagent attribution harder to resolve consistently. ## What changed - Replaces the separate thread connection and metadata maps with one reducer-owned `threads` map. - Routes guardian, compaction, turn-steer, and turn analytics through shared thread-state lookups while preserving turn-origin attribution for turn events and request-origin attribution for steer events. - Lets newly observed spawned subagent threads inherit their parent thread connection so later thread-scoped analytics can resolve through the same state model. - Adds regression coverage for standalone `SubAgentThreadStarted` publication plus the `SubAgentSource::ThreadSpawn` parent fallback through a thread-scoped consumer that depends on inherited connection state. ## Verification - `cargo test -p codex-analytics` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/20300). * #18748 * #18747 * #17090 * #17089 * #20239 * #20515 * #20514 * __->__ #20300
rhan-oai
force-pushed
the
rhan/core-item-timing-production
branch
from
88c1fb0 to
d55b667
Compare
rhan-oai
force-pushed
the
rhan/core-item-timing-production
branch
from
d55b667 to
42cdca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Protocol-native item timing needs a producer-side foundation before any public wire or replay consumer can depend on it. This stage keeps that groundwork together so the timing model can be reviewed without app-server schema churn or TUI replay changes mixed in.
Repeating
started_at_mson end events lets reducers consume a complete interval from the completion event itself instead of retaining request-time state, which keeps the timing data colocated in one place.What changed
Verification
cargo test -p codex-core web_search_item_is_emittedcargo test -p codex-protocolStack created with Sapling. Best reviewed with ReviewStack.