Skip to content

Remove deprecated DCS_SESSION_COOKIE_SAMESITE settings#38807

Open
Chessing234 wants to merge 1 commit into
openedx:masterfrom
Chessing234:fix/38757-remove-dcs-session-cookie-settings
Open

Remove deprecated DCS_SESSION_COOKIE_SAMESITE settings#38807
Chessing234 wants to merge 1 commit into
openedx:masterfrom
Chessing234:fix/38757-remove-dcs-session-cookie-settings

Conversation

@Chessing234

Copy link
Copy Markdown

Summary

  • Replace deprecated DCS_SESSION_COOKIE_SAMESITE with Django's native SESSION_COOKIE_SAMESITE in LMS settings.
  • Remove unused DCS_SESSION_COOKIE_SAMESITE_FORCE_ALL, which has had no effect since django-cookies-samesite was removed in 2021.
  • Drop the production alias SESSION_COOKIE_SAMESITE = DCS_SESSION_COOKIE_SAMESITE.

Fixes #38757

Test plan

  • Verify LMS starts with SESSION_COOKIE_SAMESITE = 'None' in common settings
  • Verify devstack still uses 'Lax' for local HTTP development

Made with Cursor

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 24, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Chessing234!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 24, 2026
@Chessing234 Chessing234 force-pushed the fix/38757-remove-dcs-session-cookie-settings branch from e48264c to 0c25305 Compare June 24, 2026 15:55
Replace legacy django-cookies-samesite settings with Django's native
SESSION_COOKIE_SAMESITE in common and devstack envs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Chessing234 Chessing234 force-pushed the fix/38757-remove-dcs-session-cookie-settings branch from 0c25305 to 1ecd13a Compare June 24, 2026 16:12
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 24, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Tests Run or CLA Signed

Development

Successfully merging this pull request may close these issues.

[DEPR]: DCS_SESSION_COOKIE_SAMESITE setting

3 participants