Skip to content

Remove deprecated DCS_SESSION_COOKIE_SAMESITE settings #38807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −10
Open

Remove deprecated DCS_SESSION_COOKIE_SAMESITE settings #38807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lms/envs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,9 +989,8 @@

############################### DJANGO BUILT-INS ###############################

# django-session-cookie middleware
DCS_SESSION_COOKIE_SAMESITE = 'None'
DCS_SESSION_COOKIE_SAMESITE_FORCE_ALL = True
# SameSite=None is required for cross-site OAuth/SSO flows over HTTPS in production.
SESSION_COOKIE_SAMESITE = 'None'

# LMS base
LMS_BASE = 'localhost:18000'
Expand Down
5 changes: 2 additions & 3 deletions lms/envs/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,8 @@ def should_show_debug_toolbar(request): # pylint: disable=missing-function-docs

#####################################################################

# django-session-cookie middleware
DCS_SESSION_COOKIE_SAMESITE = 'Lax'
DCS_SESSION_COOKIE_SAMESITE_FORCE_ALL = True
# Browsers reject SameSite=None cookies on plain HTTP devstack hosts.
SESSION_COOKIE_SAMESITE = 'Lax'

########################## THEMING #######################
# If you want to enable theming in devstack, uncomment this section and add any relevant
Expand Down
4 changes: 0 additions & 4 deletions lms/envs/production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ def get_env_setting(setting):

DATA_DIR = path(DATA_DIR) # noqa: F405

# TODO: This was for backwards compatibility back when installed django-cookie-samesite (not since 2022).
# The DCS_ version of the setting can be DEPR'd at this point.
SESSION_COOKIE_SAMESITE = DCS_SESSION_COOKIE_SAMESITE # noqa: F405

for feature, value in _YAML_TOKENS.get('FEATURES', {}).items():
FEATURES[feature] = value

Expand Down