ext/gmp: reject values larger than unsigned long in gmp_pow/binomial/…#21812
Closed
devnexen wants to merge 2 commits intophp:masterfrom
Closed
ext/gmp: reject values larger than unsigned long in gmp_pow/binomial/…#21812devnexen wants to merge 2 commits intophp:masterfrom
devnexen wants to merge 2 commits intophp:masterfrom
Conversation
…root/rootrem and shift/pow operators. Applies the gmp_fact() pattern (0236667) to the remaining zend_long -> gmp_ulong casts that could silently overflow on LLP64 platforms. gmp_powm() switches to zend_argument_error() with the correct argument index ($modulus) for modulo-by-zero.
devnexen
force-pushed
the
gmp_internal_rewrite
branch
from
8f58a73 to
6169964
Compare
mvorisek
reviewed
Apr 19, 2026
Girgias
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…root/rootrem and shift/pow operators.
Applies the gmp_fact() pattern (0236667) to the remaining zend_long -> gmp_ulong casts that could silently overflow on LLP64 platforms.
gmp_powm() switches to zend_argument_error() with the correct argument index (3 $modulus) for modulo-by-zero.