Skip to content

ext/gmp: reject values larger than unsigned long in gmp_pow/binomial/… #21812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devnexen wants to merge 2 commits into from
Closed

ext/gmp: reject values larger than unsigned long in gmp_pow/binomial/… #21812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6169964
ext/gmp: reject values larger than unsigned long in gmp_pow/binomial/…
devnexen Apr 19, 2026
7b88026
add tests
devnexen Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions ext/gmp/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,10 @@ static zend_result shift_operator_helper(gmp_binary_ui_op_t op, zval *return_val
shift = Z_LVAL_P(op2);
}

if (shift < 0) {
if (shift < 0 || shift > ULONG_MAX) {
zend_throw_error(
zend_ce_value_error, "%s must be greater than or equal to 0",
opcode == ZEND_POW ? "Exponent" : "Shift"
zend_ce_value_error, "%s must be between 0 and %lu",
opcode == ZEND_POW ? "Exponent" : "Shift", ULONG_MAX
);
ZVAL_UNDEF(return_value);
return FAILURE;
Expand Down Expand Up @@ -1087,11 +1087,6 @@ ZEND_FUNCTION(gmp_fact)
GMP_Z_PARAM_INTO_MPZ_PTR(gmpnum)
ZEND_PARSE_PARAMETERS_END();

if (mpz_sgn(gmpnum) < 0) {
zend_argument_value_error(1, "must be greater than or equal to 0");
RETURN_THROWS();
}

if (!mpz_fits_ulong_p(gmpnum)) {
zend_argument_value_error(1, "must be between 0 and %lu", ULONG_MAX);
RETURN_THROWS();
Expand All @@ -1114,8 +1109,8 @@ ZEND_FUNCTION(gmp_binomial)
Z_PARAM_LONG(k)
ZEND_PARSE_PARAMETERS_END();

if (k < 0) {
zend_argument_value_error(2, "must be greater than or equal to 0");
if (k < 0 || k > ULONG_MAX) {
zend_argument_value_error(2, "must be between 0 and %lu", ULONG_MAX);
RETURN_THROWS();
}

Expand All @@ -1136,8 +1131,8 @@ ZEND_FUNCTION(gmp_pow)
Z_PARAM_LONG(exp)
ZEND_PARSE_PARAMETERS_END();

if (exp < 0) {
zend_argument_value_error(2, "must be greater than or equal to 0");
if (exp < 0 || exp > ULONG_MAX) {
zend_argument_value_error(2, "must be between 0 and %lu", ULONG_MAX);
RETURN_THROWS();
}

Expand All @@ -1163,7 +1158,7 @@ ZEND_FUNCTION(gmp_powm)
}

if (!mpz_cmp_ui(gmpnum_mod, 0)) {
zend_throw_exception_ex(zend_ce_division_by_zero_error, 0, "Modulo by zero");
zend_argument_error(zend_ce_division_by_zero_error, 3, "Modulo by zero");
RETURN_THROWS();
}

Expand Down Expand Up @@ -1226,8 +1221,8 @@ ZEND_FUNCTION(gmp_root)
Z_PARAM_LONG(nth)
ZEND_PARSE_PARAMETERS_END();

if (nth <= 0) {
zend_argument_value_error(2, "must be greater than 0");
if (nth <= 0 || nth > ULONG_MAX) {
zend_argument_value_error(2, "must be between 1 and %lu", ULONG_MAX);
RETURN_THROWS();
}

Expand All @@ -1253,8 +1248,8 @@ ZEND_FUNCTION(gmp_rootrem)
Z_PARAM_LONG(nth)
ZEND_PARSE_PARAMETERS_END();

if (nth <= 0) {
zend_argument_value_error(2, "must be greater than or equal to 1");
if (nth <= 0 || nth > ULONG_MAX) {
zend_argument_value_error(2, "must be between 1 and %lu", ULONG_MAX);
RETURN_THROWS();
}

Expand Down
4 changes: 2 additions & 2 deletions ext/gmp/tests/gmp_binomial.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ try {
echo $e->getMessage() . \PHP_EOL;
}
?>
--EXPECT--
--EXPECTF--
object(GMP)#1 (1) {
["num"]=>
string(3) "252"
Expand Down Expand Up @@ -67,4 +67,4 @@ object(GMP)#2 (1) {
["num"]=>
string(1) "7"
}
gmp_binomial(): Argument #2 ($k) must be greater than or equal to 0
gmp_binomial(): Argument #2 ($k) must be between 0 and %d
Comment thread
Girgias marked this conversation as resolved.
8 changes: 4 additions & 4 deletions ext/gmp/tests/gmp_fact.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,17 @@ try {

echo "Done\n";
?>
--EXPECT--
--EXPECTF--
string(1) "1"
gmp_fact(): Argument #1 ($num) is not an integer string
string(1) "1"
gmp_fact(): Argument #1 ($num) must be greater than or equal to 0
gmp_fact(): Argument #1 ($num) must be greater than or equal to 0
gmp_fact(): Argument #1 ($num) must be between 0 and %d
gmp_fact(): Argument #1 ($num) must be between 0 and %d
string(19) "2432902008176640000"
string(65) "30414093201713378043612608166064768844377641568960512000000000000"
string(7) "3628800"
string(1) "1"
string(9) "479001600"
gmp_fact(): Argument #1 ($num) must be greater than or equal to 0
gmp_fact(): Argument #1 ($num) must be between 0 and %d
gmp_fact(): Argument #1 ($num) must be of type GMP|string|int, array given
Done
58 changes: 58 additions & 0 deletions ext/gmp/tests/gmp_overflow_llp64.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
--TEST--
GMP functions reject values larger than unsigned long on LLP64
--EXTENSIONS--
gmp
--SKIPIF--
<?php
if (PHP_OS_FAMILY !== "Windows" || PHP_INT_SIZE !== 8) die("skip LLP64 (Windows 64-bit) only");
?>
--FILE--
<?php

try {
gmp_pow(2, PHP_INT_MAX);
} catch (ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

try {
gmp_binomial(10, PHP_INT_MAX);
} catch (ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

try {
gmp_root(10, PHP_INT_MAX);
} catch (ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

try {
gmp_rootrem(10, PHP_INT_MAX);
} catch (ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

$n = gmp_init(2);
try {
$n << PHP_INT_MAX;
} catch (ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

try {
$n ** PHP_INT_MAX;
} catch (ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

echo "Done\n";
?>
--EXPECTF--
gmp_pow(): Argument #2 ($exponent) must be between 0 and %d
gmp_binomial(): Argument #2 ($k) must be between 0 and %d
gmp_root(): Argument #2 ($nth) must be between 1 and %d
gmp_rootrem(): Argument #2 ($nth) must be between 1 and %d
Shift must be between 0 and %d
Exponent must be between 0 and %d
Done
6 changes: 3 additions & 3 deletions ext/gmp/tests/gmp_pow.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,17 @@ try {

echo "Done\n";
?>
--EXPECT--
--EXPECTF--
string(4) "1024"
string(4) "1024"
string(5) "-2048"
string(4) "1024"
string(1) "1"
gmp_pow(): Argument #2 ($exponent) must be greater than or equal to 0
gmp_pow(): Argument #2 ($exponent) must be between 0 and %d
string(4) "1024"
string(14) "10240000000000"
string(17) "97656250000000000"
gmp_pow(): Argument #2 ($exponent) must be greater than or equal to 0
gmp_pow(): Argument #2 ($exponent) must be between 0 and %d
string(14) "10240000000000"
string(14) "10240000000000"
gmp_pow(): Argument #2 ($exponent) must be of type int, array given
Expand Down
4 changes: 2 additions & 2 deletions ext/gmp/tests/gmp_pow2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ object(GMP)#%d (1) {
["num"]=>
string(4) "1024"
}
Exponent must be greater than or equal to 0
Exponent must be greater than or equal to 0
Exponent must be between 0 and %d
Exponent must be between 0 and %d
6 changes: 3 additions & 3 deletions ext/gmp/tests/gmp_pown.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ var_dump(gmp_powm(10, $n, 10));

echo "Done\n";
?>
--EXPECT--
--EXPECTF--
string(1) "0"
string(1) "5"
string(1) "5"
Expand All @@ -73,8 +73,8 @@ string(3) "533"
string(3) "331"
string(3) "171"
string(3) "371"
Modulo by zero
Modulo by zero
gmp_powm(): Argument #3 ($modulus) Modulo by zero
gmp_powm(): Argument #3 ($modulus) Modulo by zero
gmp_powm(): Argument #1 ($num) must be of type GMP|string|int, array given
gmp_powm(): Argument #2 ($exponent) must be of type GMP|string|int, array given
gmp_powm(): Argument #2 ($exponent) must be of type GMP|string|int, TypeError given
Expand Down
4 changes: 2 additions & 2 deletions ext/gmp/tests/gmp_remroot.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ array(2) {
string(1) "0"
}
}
gmp_rootrem(): Argument #2 ($nth) must be greater than or equal to 1
gmp_rootrem(): Argument #2 ($nth) must be greater than or equal to 1
gmp_rootrem(): Argument #2 ($nth) must be between 1 and %d
gmp_rootrem(): Argument #2 ($nth) must be between 1 and %d
4 changes: 2 additions & 2 deletions ext/gmp/tests/gmp_root.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,5 @@ object(GMP)#%d (1) {
["num"]=>
string(1) "0"
}
gmp_root(): Argument #2 ($nth) must be greater than 0
gmp_root(): Argument #2 ($nth) must be greater than 0
gmp_root(): Argument #2 ($nth) must be between 1 and %d
gmp_root(): Argument #2 ($nth) must be between 1 and %d
6 changes: 3 additions & 3 deletions ext/gmp/tests/overloading.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ $a .= '17';
var_dump($a);

?>
--EXPECT--
--EXPECTF--
object(GMP)#3 (1) {
["num"]=>
string(2) "59"
Expand Down Expand Up @@ -254,8 +254,8 @@ object(GMP)#5 (1) {
["num"]=>
string(3) "-11"
}
Shift must be greater than or equal to 0
Shift must be greater than or equal to 0
Shift must be between 0 and %d
Shift must be between 0 and %d
object(GMP)#5 (1) {
["num"]=>
string(3) "-43"
Expand Down
Loading