feat(swift-ios): copy thread metadata from rows - #6134
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| return notice | ||
| } | ||
|
|
||
| mutating func finishUndo(id: UUID) { |
There was a problem hiding this comment.
🟡 Medium Workspace/WorkspaceView.swift:104
finishUndo clears the notice unconditionally, even when the undo operation fails. Because the caller invokes it from a defer block, if model.setSettled(..., settled: false) (or a subsequent pin/snooze restoration) returns false, the thread stays settled or partially restored while the undo notice disappears — leaving the user with no way to retry. Consider clearing the notice only when the undo succeeded, or resetting undoInProgressID while preserving the notice on failure so the user can retry.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Workspace/WorkspaceView.swift around line 104:
`finishUndo` clears the notice unconditionally, even when the undo operation fails. Because the caller invokes it from a `defer` block, if `model.setSettled(..., settled: false)` (or a subsequent pin/snooze restoration) returns `false`, the thread stays settled or partially restored while the undo notice disappears — leaving the user with no way to retry. Consider clearing the notice only when the undo succeeded, or resetting `undoInProgressID` while preserving the notice on failure so the user can retry.
What Changed
Dependency
Stacked on the swipe-safety work in #6117. Review commit
7280970f6for this feature until that PR lands.Verification
ThreadMetadataCopyTestsand the affected sidebar suites passed on iOS Simulator after rebasing onto fix(swift-ios): make thread swipe actions safe #6117git diff --check: passedUI
Copy Metadata is available from the thread row context menu and copies a readable multi-line summary.
Note
Add thread metadata copy menu and settle undo toast to iOS sidebar
setSettled,setSnoozed, andsetPinnedin FeatureRootModel.swift now returnBoolindicating mutation success, used by the undo flow to conditionally restore state.📊 Macroscope summarized 7280970. 5 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.