Fix N+1 queries on nominations admin changelists - #3086
Merged
Conversation
`NomineeAdmin.list_display` starts with `__str__`, and `Nominee.__str__` resolves to `self.user.first_name`, so the changelist issued one `SELECT users_user...` per row, plus one per row for the `election` column. `NominationAdmin` hit the same thing through its `nominee` column, which renders `Nominee.__str__`. Select the displayed relations in `get_queryset()` on both admins. Refs PYDOTORG-PROD-1N8 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR optimizes Django admin changelist performance in the nominations app by preloading related objects used in list_display/ordering, eliminating N+1 query patterns when browsing nominees and nominations in the admin.
Changes:
- Add
NomineeAdmin.get_queryset()withselect_related("user", "election")to avoid per-row lookups. - Add
NominationAdmin.get_queryset()withselect_related("election", "nominee__user")to avoid per-row lookups for nominee/user and election.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves PYDOTORG-PROD-1N8