Skip to content

Fix N+1 queries on nominations admin changelists #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 1 commit into from
Aug 11, 2026
+8 −0
Merged

Fix N+1 queries on nominations admin changelists #3086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/nominations/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ class NomineeAdmin(admin.ModelAdmin):
list_filter = ("election", "accepted", "approved")
readonly_fields = ("slug",)

def get_queryset(self, request):
"""Select the relations rendered in ``list_display`` to avoid per-row queries."""
return super().get_queryset(request).select_related("user", "election")

def get_ordering(self, request):
"""Return ordering by election and last name."""
return ["election", Lower("user__last_name")]
Expand Down Expand Up @@ -61,6 +65,10 @@ class NominationAdmin(admin.ModelAdmin):
"eligibility_confirmed",
)

def get_queryset(self, request):
"""Select the relations rendered in ``list_display`` to avoid per-row queries."""
return super().get_queryset(request).select_related("election", "nominee__user")

def get_ordering(self, request):
"""Return ordering by election and nominee last name."""
return ["election", Lower("nominee__user__last_name")]