-
Notifications
You must be signed in to change notification settings - Fork 781
[slimtensor] Storage and SharedPtr for CPU owning mode #16383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/gasoonjia/74/base
Are you sure you want to change the base?
Conversation
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16383
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Pending, 1 Unrelated FailureAs of commit 5a10dcc with merge base 9a30bd3 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
- util/SharedPtr.h - A lightweight, non-thread-safe shared pointer optimized for single-threaded tensor operations.
- core/Storage.h - The MaybeOwningStorage class that manages tensor data memory:
- DeviceTraits<CPU> specialization with allocate(), free(), memcpy() using malloc/free
- Owning mode for CPU device (CUDA and non-owning mode added later)
- Storage type alias as SharedPtr<MaybeOwningStorage>
- Move semantics for efficient resource transfer
- clone() and copy_() methods for data management
Differential Revision: [D89747980](https://our.internmc.facebook.com/intern/diff/D89747980/)
[ghstack-poisoned]
Stack from ghstack (oldest at bottom):
This diff introduces the foundation for tensor storage management in the SlimTensor migration:
Differential Revision: D89747980