Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Dec 26, 2025

Stack from ghstack (oldest at bottom):

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

Key components:

  1. factory/Empty.h - Factory functions for creating empty tensors:

    • empty_strided(sizes, strides, dtype, device) - Creates tensor with explicit sizes/strides
    • empty(sizes, dtype, device) - Creates contiguous tensor (auto-computes row-major strides)
    • empty(initializer_list, dtype, device) - Convenience overload for inline size specification
    • empty_like(tensor) - Creates empty tensor with same metadata as another tensor
  2. core/Storage.h - Added new_storage() helper function:

    • Computes required storage bytes from sizes, strides, and dtype
    • Allocates and returns a new owning Storage instance

Differential Revision: D89820292

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16398

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 3cecf47 with merge base 9a30bd3 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants