Skip to content

feat: [combobox] add createItems for id-based values - #946

Open
ravisuhag wants to merge 2 commits into
chore/base-ui-1-8from
feat/combobox-create-items
Open

ravisuhag wants to merge 2 commits into
chore/base-ui-1-8from
feat/combobox-create-items

Conversation

@ravisuhag

@ravisuhag ravisuhag commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add Combobox.createItems from Base UI 1.8. It wraps a data array with getValue and getLabel, so value and onValueChange use IDs while the list renders full items.
  • Add an Item type parameter to the root prop types. It defaults to Value, so existing code type-checks as before.
  • Combobox.Content accepts a function child that renders each item matching the input when items is set.
  • Multi-select chips show the item label from getLabel, not the raw value. Before, a chip showed the ID.
  • Add a "Using IDs as values" docs section and tests.

Stacked on #945. Merge that first.

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
apsara Ready Ready Preview Oct 8, 2026 1:20am UTC

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d571a8cf-5808-44f6-9886-7b94f1390c15
📥 Commits

Reviewing files that changed from the base of the PR and between d715734 and 086e18a.

📒 Files selected for processing (9)
  • apps/www/src/content/docs/components/combobox/demo.ts
  • apps/www/src/content/docs/components/combobox/index.mdx
  • apps/www/src/content/docs/components/combobox/props.ts
  • packages/react/components/combobox/__tests__/combobox.test.tsx
  • packages/react/components/combobox/combobox-content.tsx
  • packages/react/components/combobox/combobox-input.tsx
  • packages/react/components/combobox/combobox-items.ts
  • packages/react/components/combobox/combobox-root.tsx
  • packages/react/components/combobox/combobox.tsx
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@946

commit: 086e18a

This branch was successfully deployed

1 active deployment
Preview — 086e18a3 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant