Skip to content

chore!: remove deprecated name and namespace fields from frontier permission protos - #500

Open
whoAbhishekSah wants to merge 1 commit into
mainfrom
refactor/remove-deprecated-permission-fields
Open

chore!: remove deprecated name and namespace fields from frontier permission protos#500
whoAbhishekSah wants to merge 1 commit into
mainfrom
refactor/remove-deprecated-permission-fields

Conversation

@whoAbhishekSah

Copy link
Copy Markdown
Member

Summary

Removes the deprecated name and namespace fields from the frontier Permission message (models.proto) and PermissionRequestBody (admin.proto). The key field (service.resource.verb) is the sole way to express a permission's identity in both requests and responses. Final proto step of raystack/frontier#1782.

Why this is safe

Changes

  • raystack/frontier/v1beta1/models.proto: drop Permission.name (2) and Permission.namespace (6); reserve the numbers and names; document key.
  • raystack/frontier/v1beta1/admin.proto: drop PermissionRequestBody.name (1) and .namespace (2); reserve the numbers and names.

Test Plan

  • buf lint passes
  • buf breaking --against main passes

🤖 Generated with Claude Code

…mission protos

The Permission message and PermissionRequestBody carry the permission
identity in the key field ('service.resource.verb'). The deprecated
name and namespace fields are no longer read or populated by frontier,
so drop them and reserve their numbers and names.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedAug 20, 2026, 7:57 AM

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 56d063a3-425a-4093-acd4-76f969bc6cf8

📥 Commits

Reviewing files that changed from the base of the PR and between c7755be and b4b467d.

📒 Files selected for processing (2)
  • raystack/frontier/v1beta1/admin.proto
  • raystack/frontier/v1beta1/models.proto

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The protobuf definitions remove the deprecated name and namespace fields from PermissionRequestBody and Permission. Their field numbers and names are reserved for compatibility. Permission also removes validation for name and documents the three-part key format.

Suggested reviewers: rohilsurana, amangit07

Merge Risk: ⚪ Minimal · up to b4b46

This change removes deprecated permission fields while preserving reserved wire identifiers and using the existing key field as the identity; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of deprecated fields from the Frontier permission protos.
Description check ✅ Passed The description directly explains the removed fields, reserved identifiers, compatibility considerations, and validation results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rohilsurana

Copy link
Copy Markdown
Member

Check CheckResourcePermissionRequest message in frontier.proto files as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants