chore!: remove deprecated name and namespace fields from frontier permission protos - #500
chore!: remove deprecated name and namespace fields from frontier permission protos#500whoAbhishekSah wants to merge 1 commit into
Conversation
…mission protos
The Permission message and PermissionRequestBody carry the permission
identity in the key field ('service.resource.verb'). The deprecated
name and namespace fields are no longer read or populated by frontier,
so drop them and reserve their numbers and names.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe protobuf definitions remove the deprecated Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change removes deprecated permission fields while preserving reserved wire identifiers and using the existing key field as the identity; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Check |
Summary
Removes the deprecated
nameandnamespacefields from the frontierPermissionmessage (models.proto) andPermissionRequestBody(admin.proto). Thekeyfield (service.resource.verb) is the sole way to express a permission's identity in both requests and responses. Final proto step of raystack/frontier#1782.Why this is safe
keyround-trips losslessly (fix(permission): make the response key lossless and migrate its readers frontier#1887).buf breaking(WIRE) passes.name/namespacegets the same behavior it gets today (the server no longer reads them). Clients that read the removed response fields must move tokey; frontier will call this out in its release notes.Changes
raystack/frontier/v1beta1/models.proto: dropPermission.name(2) andPermission.namespace(6); reserve the numbers and names; documentkey.raystack/frontier/v1beta1/admin.proto: dropPermissionRequestBody.name(1) and.namespace(2); reserve the numbers and names.Test Plan
buf lintpassesbuf breaking --against mainpasses🤖 Generated with Claude Code