Skip to content

chore!: remove deprecated name and namespace fields from frontier permission protos #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whoAbhishekSah wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −12
Open

chore!: remove deprecated name and namespace fields from frontier permission protos #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions raystack/frontier/v1beta1/admin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,14 +293,13 @@ message DeleteRoleRequest {
message DeleteRoleResponse {}

message PermissionRequestBody {
string name = 1 [deprecated = true];
// namespace should be in service/resource format
string namespace = 2 [deprecated = true];
reserved 1, 2;
reserved "name", "namespace";

google.protobuf.Struct metadata = 3;
string title = 4;

// key is composed of three parts, 'service.resource.verb'. Where 'service.resource' works as a namespace for the 'verb'.
// Use this instead of using name and namespace fields
string key = 5;
}

Expand Down
12 changes: 4 additions & 8 deletions raystack/frontier/v1beta1/models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,19 +154,15 @@ message Relation {
}

message Permission {
reserved 2, 6;
reserved "name", "namespace";

string id = 1;
string name = 2 [
(buf.validate.field).string = {
min_len: 2
pattern: "^[A-Za-z0-9]+$"
},
deprecated = true
];
string title = 3;
google.protobuf.Timestamp created_at = 4;
google.protobuf.Timestamp updated_at = 5;
string namespace = 6 [deprecated = true];
google.protobuf.Struct metadata = 7;
// key is composed of three parts, 'service.resource.verb'. Where 'service.resource' works as a namespace for the 'verb'.
string key = 8;
}

Expand Down
Loading