[cppyy] Check early for conversion to initializer list #21053
Conversation
|
Obvious follow-up question: why do we need to default construct objects for conversion to initializer list, but not for vector? But since I'm ok with the vector overload for my case in the histograms, I'm not going to look further into this... |
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks! I only have minor formatting comments, but the changes look perfect to me!
Obvious follow-up question: why do we need to default construct objects for conversion to initializer list, but not for vector?
I don't know, but since the changes in this PR make sense no matter what the answer to that question is, I can look into this later.
It requires to construct default objects. Before it would blindly call Cppyy::Construct and check the return value. This leads to a confusing error message from TClass::New even though conversion to std::vector subsequently succeeds (which doesn't need to construct default objects).
Test Results 22 files 22 suites 3d 10h 55m 39s ⏱️ Results for commit f8804d0. ♻️ This comment has been updated with latest results. |
hahnjo
force-pushed
the
cppyy-initializer_list
branch
from
cbf7522 to
f8804d0
Compare
2 participants
It requires to construct default objects. Before it would blindly call
Cppyy::Constructand check the return value. This leads to a confusing error message fromTClass::Neweven though conversion tostd::vectorsubsequently succeeds (which doesn't need to construct default objects).