remove calls to AliasTyKind::def_id#155356
Open
WilliamTakeshi wants to merge 1 commit intorust-lang:mainfrom
Open
remove calls to AliasTyKind::def_id#155356WilliamTakeshi wants to merge 1 commit intorust-lang:mainfrom
WilliamTakeshi wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
WaffleLapkin
approved these changes
Apr 15, 2026
Member
|
r=me with green CI |
Contributor
|
✌️ @WilliamTakeshi, you can now approve this pull request! If @WaffleLapkin told you to " |
Member
|
@bors r=WaffleLapkin rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
…_id, r=WaffleLapkin remove calls to AliasTyKind::def_id ref rust-lang#154941 I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id` This is the list checked: - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1 - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1 - [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5 - [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2 - [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3 - [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1 - [X] compiler/rustc_middle/src/ty/sty.rs — 1 - [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3 - [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3 - [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1 - [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4 - [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2 - [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1 - [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1 - [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7 - [X] compiler/rustc_ty_utils/src/ty.rs — 1 - [X] compiler/rustc_type_ir/src/outlives.rs — 1 - [X] compiler/rustc_type_ir/src/predicate.rs — 1 - [X] compiler/rustc_type_ir/src/relate.rs — 5 - [X] compiler/rustc_type_ir/src/ty_kind.rs — 2 r? @WaffleLapkin
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
…_id, r=WaffleLapkin remove calls to AliasTyKind::def_id ref rust-lang#154941 I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id` This is the list checked: - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1 - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1 - [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5 - [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2 - [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3 - [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1 - [X] compiler/rustc_middle/src/ty/sty.rs — 1 - [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3 - [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3 - [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1 - [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4 - [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2 - [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1 - [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1 - [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7 - [X] compiler/rustc_ty_utils/src/ty.rs — 1 - [X] compiler/rustc_type_ir/src/outlives.rs — 1 - [X] compiler/rustc_type_ir/src/predicate.rs — 1 - [X] compiler/rustc_type_ir/src/relate.rs — 5 - [X] compiler/rustc_type_ir/src/ty_kind.rs — 2 r? @WaffleLapkin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #154941
I asked the LSP where
AliasTyKind::def_idand then checked where theAliasTyKind::def_idwas trivial to change. Could only find 2 places, and I am not sure about theopaque_types.rs(open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex asAliasTyKind::def_idThis is the list checked:
r? @WaffleLapkin