Rollup of 18 pull requests#155380
Merged
rust-bors[bot] merged 56 commits intorust-lang:mainfrom Apr 16, 2026
Merged
Conversation
Shaves off 368 bytes from the total size of all Unicode data tables.
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.
This allows warnings to be annotated, and verifies that no unexpected warnings occur.
* Adds musl CVE fix to compiler section * Removes Cargo section per feedback in the PR
`DroplessArena::alloc` already disallows ZST allocation. `TypedArena::alloc` allows it but: - (a) it's never used, and - (b) writing to `NonNull::dangling()` seems dubious, even if the write is zero-sized. This commit just changes it to panic on a ZST. This eliminates an untested code path, and we shouldn't be allocating ZSTs anyway. It also eliminates an unused ZST code path in `clear_last_chunk`. Tests are also updated accordingly.
Co-authored-by: Josh Stone <[email protected]>
This adds a `--quiet` flag to x.py and bootstrap to suppress some of the output when compiling Rust. It conflicts with `--verbose`, matching the behavior of `cargo` which does not allow `--verbose` and `--quiet`. It works by passing quiet flags down to the underlying cargo, or LLVM build processes. Note that for LLVM, we only can suppress logs when we explicitly configure it with ninja. Otherwise we won't know what flag to pass along to whichever build system cmake decides to use. This can be helpful with AI workloads in the Rust codebase to help shrink down the output to reduce token usage, which can help prevent context pollution and lower costs. This patch was partially generated with Gemini, but I've reviewed the changes it made.
Co-authored-by: Josh Stone <[email protected]>
rust-bors
bot
added
S-waiting-on-bors
Member
|
The queue is fairly long, so let's run a few try jobs in parallel while we're waiting. @bors try jobs=x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Rollup of 18 pull requests try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
This was referenced Apr 16, 2026
resolve: Introduce
(Local,Extern)Module newtypes for local and external modules respectively
#155242
Open
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d227e48 (parent) -> 7af3402 (this PR) Test differencesShow 237 test diffsStage 0
Stage 1
Stage 2
Additionally, 168 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7af3402cda75aaead39f72516fd6cbb2f3ee0dbd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: d227e48c56 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 16, 2026
Collaborator
|
Finished benchmarking commit (7af3402): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.2%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.1%, secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 492.446s -> 509.515s (3.47%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
<_ as Try>::Residualimplement theResidualtrait #154451 (Require that a<_ as Try>::Residualimplement theResidualtrait)varargs_without_patternlint in deps #154599 (report thevarargs_without_patternlint in deps)core::unicode: ReplaceCasedtable withLt#154699 (core::unicode: ReplaceCasedtable withLt)inaccessible_ctor_reexportresolver field #155353 (resolve: Removeinaccessible_ctor_reexportresolver field)--remap-path-scopeas unstable in rustdoc #155357 (Add--remap-path-scopeas unstable in rustdoc)--quietflag to x.py and bootstrap to suppress output #154616 (Add--quietflag to x.py and bootstrap to suppress output)AttributeLintKindand refactor diagnostic attribute linting #155215 (Clean upAttributeLintKindand refactor diagnostic attribute linting)cpassandrpassrevisions #155228 (Check diagnostic output in incrementalcpassandrpassrevisions)TypedArena. #155326 (Disallow ZST allocations withTypedArena.)0b1instead ofNonZero::MINinNonZero::bit_widthdoctests #155334 (docs: Use0b1instead ofNonZero::MINinNonZero::bit_widthdoctests)r? @ghost
Create a similar rollup