Skip to content

chore(explorer): clean up leftovers in the docs page, runner and API - #41

Merged
polakamtejas merged 7 commits into
mainfrom
tejas/explorer-cleanup
Oct 3, 2026
Merged

polakamtejas merged 7 commits into
mainfrom
tejas/explorer-cleanup

Conversation

@polakamtejas

@polakamtejas polakamtejas commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Cleanup of explorer leftovers found during the OSS pass. One commit per item.

  • OpenAPI version: reports the installed agentenv-framework version instead of a hardcoded 0.1.0.
  • Docs page: removed the hosted hub's published-spec branch (Commit / Bucket / key rows, "Spec commit"). The explorer always serves its spec live. The header "Version" line goes too, since the This Hub rows (fix(explorer): show the framework version on a live spec's overview #36) already show both versions.
  • Task runner: removed the dead evaluator-return flow and the state only it used (nothing passes onEditEvaluator / onRerunFromStep).
  • Stale docs: rewrote ui/README.md; the prompt_agent docstring says object store, not S3.
  • API:
    • /{id}/versions is now a 404 for an unknown id, like GET /{id}. Both UI callers already handle a 404.
    • /objects/metadata reports the same content type /objects/content serves.
  • ESLint: npm run lint runs ESLint 9 with eslint-config-next (no longer the deprecated next lint). It found 3 errors, now fixed, and CI's ui job now runs lint. 61 warnings are deferred (mostly unused vars).

Testing

  • 3 new tests, which fail on main and pass here. Explorer tests: 102 passed. Unit tier green apart from 2 env-only test_mcp_cli_builder failures that also fail on main. No plugin-API break.
  • UI: typecheck, lint, smoke and build pass.
  • Browser check against agent-env up: the Docs page shows the real versions with no Bucket rows, the runner runs, and universe pages load.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the changes since the previous review introduce no actionable issue.

Summary

The explorer now reports live package and object details more consistently, and its Docs page shows only metadata for the live hub. The PR also removes an unused task-runner rerun path and updates the UI lint and setup docs.

  • Aligns OpenAPI and object metadata with the running installation and served content.
  • Makes version-list responses distinguish unknown entities from empty pages.
  • Removes unused evaluator-return state and updates UI linting and documentation.

Reviews (2) · Last reviewed commit: "docs(explorer): trim the versions and co..."

polakamtejas and others added 6 commits October 1, 2026 18:55
… OpenAPI spec

The FastAPI app was built with a hardcoded version "0.1.0", which Swagger and any spec consumer showed. It now takes the installed agentenv-framework version through openapi_docs.package_version (public now that app.py uses it).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The explorer always serves its spec live, so the hosted hub's published-spec path never runs: the Commit / Bucket / Latest key / Version key rows, the "Spec commit" lines in the header and sidebar, and the metadata fields only they read. The header's "Version" line goes too; the This Hub rows already show the framework and protocol versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing passes onEditEvaluator or onRerunFromStep, and handleEvaluatorSaved was only stored in a ref nothing read, so the flow and the context it captured never ran: pendingEvalRun and its effect, lastContextJson / lastContextSource, the savedContextJson / onContextCaptured props, the poll's latestCompleted, and EVALUATOR_STEP_TYPES. The app shell's write-only editTaskId, cloneTaskId, evaluatorOnlyTaskId and rerunFromStep state goes with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… saves trigger state

The UI README still said its docs would land with the OSS release; it now covers developing against agent-env up, building the static export it serves, and links the user guide. prompt_agent's trigger-state docstring said S3; it writes to the configured object store.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t's served content type

GET /{collection}/{id}/versions answered 200 [] for an id with no versions while GET /{id} 404s; it now 404s too, and a page past the last version of a stored entity is still []. The UI's two callers already treat a non-OK response as no versions. GET /objects/metadata returned content_type null for stores that keep none; it now reports the type /objects/content serves, from the shared fallback to the filename. Tests cover both and the OpenAPI version from the first commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npm run lint ran next lint, which prompted for setup and is deprecated in Next 15.5. It now runs eslint with a flat config extending next/core-web-vitals and next/typescript (eslint 9, eslint-config-next 15.5.25, matching next). The three errors it found were unescaped apostrophes in JSX; 61 warnings remain and do not fail the run. The CI ui job runs the lint after the typecheck.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@polakamtejas
polakamtejas requested a review from a team as a code owner October 1, 2026 22:55
@socket-security

socket-security Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​eslint@​9.39.59710010050100
Addednpm/​eslint-config-next@​15.5.25991006598100
Addednpm/​@​eslint/​eslintrc@​3.3.79910010089100

View full report

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@polakamtejas
polakamtejas merged commit cf208a6 into main Oct 3, 2026
14 checks passed
@polakamtejas
polakamtejas deleted the tejas/explorer-cleanup branch October 3, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants