refactor: remove unused ChangeDetectionStrategy from LoginComponent and LoggedInComponent - #591
Merged
timdeschryver merged 2 commits intoJul 30, 2026
Conversation
…nd LoggedInComponent
Contributor
Author
|
@timdeschryver The 4 failing tests in projects/testing-library/src/tests/zoneless.spec.ts are not caused by this PR. They were pre-existing before this branch — running the tests on a clean checkout (no local changes) produces the same 4 failures. |
Member
|
@JeevanMahesha yea, I also noticed it. Let me fix those first before merging this PR. |
Member
|
@JeevanMahesha feel free to update this branch, those tests should succeed now. Sorry for the inconvenience. |
timdeschryver
approved these changes
Jul 30, 2026
timdeschryver
left a comment
timdeschryver
left a comment
Member
There was a problem hiding this comment.
Thanks @JeevanMahesha !
Member
|
@all-contributors please add @JeevanMahesha for docs |
Contributor
|
I've put up a pull request to add @JeevanMahesha! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.