Skip to content

refactor: remove unused ChangeDetectionStrategy from LoginComponent and LoggedInComponent #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timdeschryver merged 2 commits into from
Jul 30, 2026
+10 −6
Merged

refactor: remove unused ChangeDetectionStrategy from LoginComponent and LoggedInComponent #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd0726f
refactor: remove unused ChangeDetectionStrategy from LoginComponent a…
Jul 24, 2026
ba7a759
ci: fix test suite
timdeschryver Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"cli": {
"analytics": false,
"cache": {
"enabled": true,
"enabled": false,
"path": "./.cache/angular",
"environment": "all"
}
Expand Down Expand Up @@ -32,9 +32,17 @@
},
"defaultConfiguration": "production"
},
"test-build-zoneless": {
"builder": "@angular/build:application",
"options": {
"polyfills": [],
"tsConfig": "projects/testing-library/tsconfig.spec.json"
}
},
"test": {
"builder": "@angular/build:unit-test",
"options": {
"buildTarget": "testing-library:test-build-zoneless",
"setupFiles": ["projects/testing-library/test-setup.ts"]
}
},
Expand Down
6 changes: 1 addition & 5 deletions apps/example-app-karma/src/app/issues/issue-491.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, inject, ChangeDetectionStrategy } from '@angular/core';
import { Component, inject } from '@angular/core';
import { Router } from '@angular/router';
import { render, screen } from '@testing-library/angular';
import userEvent from '@testing-library/user-event';
Expand Down Expand Up @@ -35,8 +35,6 @@ it('test click event with router.navigate', async () => {
});

@Component({
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
changeDetection: ChangeDetectionStrategy.Eager,
template: `
<h1>Login</h1>
<button type="submit" (click)="onSubmit()">submit</button>
Expand All @@ -52,8 +50,6 @@ class LoginComponent {
}

@Component({
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
changeDetection: ChangeDetectionStrategy.Eager,
template: ` <h1>Logged In</h1> `,
})
class LoggedInComponent {}