Repository navigation
Fix the linters broken by tool upgrades - #10
Closed
gaborbernat wants to merge 4 commits into
Closed
gaborbernat wants to merge 4 commits into
gaborbernat wants to merge 4 commits into
Conversation
pluggy passes a hook implementation only the arguments it names, so the plugin no longer has to accept the core configuration set it never reads. That also removes the two suppression comments, which ruff rewrote into a line flake8 now rejects as too long. Assisted-by: LLM
Ruff now flags autouse fixtures. Listing the fixture in pytest's `usefixtures` setting keeps it applied to every test. That setting starts it before tox's own environment check, so the fixture now keeps its own monkeypatch and restores the environment after that check. Assisted-by: LLM
pylint-pytest crashes on any module under pytest 9.2, which broke the pylint hook. The constraint stays until the plugin supports it: pylint-dev/pylint-pytest#163 Assisted-by: LLM
Automation signalsActivity patterns show signs of automation. Evidence
Last 5 PRs:
This is an automated analysis by AgentScan |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Member
Author
|
Closing: these lint fixes are out of scope for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The linters on
mainfail in both the push and the nightly runs, after hook and dependency upgrades rather than any code change:flake8rejects the hook signature line as too long, because ruff rewrote itsnoqacomment into a longerruff: ignoreone. The plugin no longer takes the core configuration argument it never used, so neither suppression is needed: pluggy passes a hook implementation only the arguments it names.ruffnow flags the autouse fixture that hides the user's tox configuration. The fixture is listed inpytest.ini'susefixturesinstead, and keeps its own monkeypatch, because pytest starts it before tox's check that a test leaves the environment unchanged.pylintcrashes on every module because pylint-pytest does not support pytest 9.2 yet (pylint-dev/pylint-pytest#163). The pylint hook keeps pytest below 9.2 until it does.mainincluded: the step that tells Codecov all uploads are in sends no token, and Codecov requires one for branches of this repository. It now passes the sameCODECOV_TOKENthe upload steps already use.Each fix is its own commit; the hook constraint can move to a separate PR if you prefer.
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
The pytest constraint on the pylint hook needs removing once pylint-pytest#163 is fixed.
Related issue number
None.
Checklist
code of conduct
🤖 Produced by a probabilistic agent with a token generator using an LLM to sound convincing.