Fix the linters broken by tool upgrades

.github/workflows/ci-cd.yml

@@ -596,6 +596,7 @@ jobs:
         fail_ci_if_error: >-
           ${{ fromJSON(needs.pre-setup.outputs.is-upstream-repository) }}
         run_command: send-notifications
+        token: ${{ secrets.CODECOV_TOKEN }}
 
   publish-pypi:
     name: >-

.pre-commit-config.yaml

@@ -291,6 +291,9 @@ repos:
     additional_dependencies:
     - covdefaults  # needed by pylint-pytest due to pytest-cov loading coverage
     - pylint-pytest ~= 2.0.0a0
+    # pylint-pytest crashes on pytest 9.2:
+    # https://github.com/pylint-dev/pylint-pytest/issues/163
+    - pytest < 9.2
     - pytest-cov  # needed by pylint-pytest since it picks up pytest's args
     - pytest-xdist  # needed by pylint-pytest since it picks up pytest's args
     - pytest-subtests

pytest.ini

@@ -77,4 +77,7 @@ norecursedirs =
 
 testpaths = tests/
 
+usefixtures =
+  _isolate_user_environment
+
 xfail_strict = true

src/tox_plugins/pre_commit/_plugin.py

@@ -13,7 +13,6 @@
 if _t.TYPE_CHECKING:
     from collections import abc as _c  # noqa: WPS347
 
-    from tox.config.sets import ConfigSet
     from tox.session.state import State
 
 
@@ -37,13 +36,9 @@ def tox_extend_envs() -> _c.Iterable[str]:
 
 
 @impl
-def tox_add_core_config(
-    core_conf: ConfigSet,  # ruff: ignore[unused-function-argument]  # pylint: disable=unused-argument
-    state: State,
-) -> None:
+def tox_add_core_config(state: State) -> None:
     """Inject default configuration for the pre-commit environment.
 
-    :param core_conf: The core tox configuration set (unused).
     :param state: The tox session state to inject environments into.
     """
     pos_args = state.conf.pos_args(to_path=None)

tests/conftest.py

@@ -3,17 +3,26 @@
 from __future__ import annotations
 
 import os
+import typing as _t
 
 import pytest
 
 
+if _t.TYPE_CHECKING:
+    from collections import abc as _c  # noqa: WPS347
+
+
 pytest_plugins = ('tox.pytest',)
 
 
-@pytest.fixture(autouse=True)
-def _isolate_user_environment(monkeypatch: pytest.MonkeyPatch) -> None:
+@pytest.fixture
+def _isolate_user_environment() -> _c.Iterator[None]:
     """Isolate the tests from the user's tox configuration.
 
-    :param monkeypatch: Pytest's environment-manipulation fixture.
+    :yields: Control to the test while the user configuration is hidden.
     """
-    monkeypatch.setenv('TOX_USER_CONFIG_FILE', os.devnull)
+    # `usefixtures` starts this before tox's environment check, so its own
+    # monkeypatch must outlive that check rather than share the test's one
+    with pytest.MonkeyPatch.context() as monkeypatch:
+        monkeypatch.setenv('TOX_USER_CONFIG_FILE', os.devnull)
+        yield