fix(crawler): clean up Playwright driver on __aenter__ failure (#2155) - #2197
Open
Battleplus wants to merge 1 commit into
Open
fix(crawler): clean up Playwright driver on __aenter__ failure (#2155)#2197Battleplus wants to merge 1 commit into
Battleplus wants to merge 1 commit into
Conversation
…code#2155) When browser launch fails inside __aenter__, the exception propagated without closing the partially-initialized crawler, leaking a live 'node run-driver' child process. Each failed attempt grew the process count linearly. Add try/except in __aenter__ to call close() on failure before re-raising. Closes unclecode#2155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2155 — When browser launch fails inside aenter, the exception propagated without closing the partially-initialized crawler, leaking a live 'node run-driver' child process. Each failed attempt grew the process count linearly.
Fix
Add try/except in aenter to call close() on failure before re-raising.
Files changed