Skip to content

fix(crawler): clean up Playwright driver on __aenter__ failure (#2155) #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Battleplus wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(crawler): clean up Playwright driver on __aenter__ failure (#2155) #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crawl4ai/async_webcrawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,17 @@ async def close(self):
await self.crawler_strategy.__aexit__(None, None, None)

async def __aenter__(self):
return await self.start()
try:
return await self.start()
except Exception:
# Ensure partially-initialised Playwright driver is cleaned up
# when browser launch fails inside __aenter__. Without this,
# each failed attempt leaks a live `node run-driver` child. (#2155)
try:
await self.close()
except Exception:
pass
raise

async def __aexit__(self, exc_type, exc_val, exc_tb):
await self.close()
Expand Down