SP ARMv3 assembly: fix for Montogmery Multiply - #11274
Merged
Merged
Conversation
Contributor
Author
|
Code generated by PR: |
|
Can one of the admins verify this patch? |
Contributor
Author
|
Jenkins: retest this please |
Code never worked and crashed. Fixed and passes tests now.
SparkiDev
force-pushed
the
sp_armv3_fix
branch
from
August 26, 2026 08:04
020d27c to
751c0a4
Compare
Contributor
Author
|
Jenkins: retest this please |
philljj
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code never worked and crashed.
Fixed and passes tests now.
Fixes F-7958, F-7959
Testing
./configure --disable-shared LDFLAGS=--static --host=armv3 CC=arm-linux-gnueabi-gcc CFLAGS=-DWOLFSSL_ARM_ARCH=3 --enable-sp --enable-sp-asm