refactor: Separate registry logic from ChunkGrid base class (fixes #3734)#3814
Closed
abishop1990 wants to merge 4 commits intozarr-developers:mainfrom
Closed
refactor: Separate registry logic from ChunkGrid base class (fixes #3734)#3814abishop1990 wants to merge 4 commits intozarr-developers:mainfrom
abishop1990 wants to merge 4 commits intozarr-developers:mainfrom
Conversation
…rr-developers#3734) - Remove ChunkGrid.from_dict class method that handled registry dispatch - Create new parse_chunk_grid function to handle deserialization - Update ArrayV3Metadata to use parse_chunk_grid instead of ChunkGrid.from_dict - Follows the same pattern as parse_chunk_key_encoding for consistency - Improves separation of concerns by removing registry responsibility from base class
Contributor
Contributor
Author
|
Closing: Changelog validation continues to fail despite multiple fixes. The approach needs review before re-opening. Issue #3734 remains open for future work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the ChunkGrid base class to remove registry responsibility.
Changes
ChunkGrid.from_dictclass method that handled dispatch to subclassesparse_chunk_gridfunction to handle deserialization and dispatchArrayV3Metadatato useparse_chunk_gridinstead ofChunkGrid.from_dictBenefits
parse_chunk_key_encodingTesting